feat: Add azure blob storage support #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it's easier to see what is missing in debug messages.
rushtehrani
changed the title
rushtehrani
reviewed
Jan 7, 2021
| @@ -4,7 +4,7 @@ import ( | |||
| "encoding/base64" | |||
| "errors" | |||
| "fmt" | |||
| v1 "github.com/onepanelio/core/pkg" | |||
| "github.com/onepanelio/cli/cloud/storage" | |||
There was a problem hiding this comment.
@rushtehrani I'm working on removing the dependency on onepanel-core. Without this change, I'd have to update onepanel-core with these changes and pull the updated version. I think I just need the ptr utils and that's it.
There was a problem hiding this comment.
@rushtehrani Actually, looks like that was it. No further need for the dependency.
There was a problem hiding this comment.
got it, we'd have to eventually pull these into a shared package.
There was a problem hiding this comment.
@rushtehrani Agreed.
…been updated in the manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer: